fix(latch): bump default jitter tolerance from 20 to 25#524
Merged
Conversation
chmanie
approved these changes
May 16, 2026
Member
chmanie
left a comment
chmanie
left a comment
There was a problem hiding this comment.
Nice touch with the tests. Let's see how useful they'll be in the future!
chmanie
requested changes
May 16, 2026
Member
chmanie
left a comment
chmanie
left a comment
There was a problem hiding this comment.
Actually let's get the configurator fixes out of this
ADC noise on the MAX11300 fader inputs can reach ~20 LSBs in practice; a tolerance of 20 was too tight and caused false updates when the fader was held still. 25 LSBs (~0.6% of full scale) provides a reliable noise margin while still responding to deliberate movements of 26+ steps. Adds characterization tests: held-fader noise simulation, boundary check at tolerance±1, and slow-creep accumulation to document the emission rate.
chmanie
force-pushed
the
fix/latch-jitter-tolerance
branch
from
b9232a6 to
9f6c4b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnalogLatch's default jitter tolerance from 20 → 25 LSB (~0.6% of full scale). The 20 was too tight against measured ADC noise on real hardware and produced occasional false latch updates when faders were held still.