Used NumPy functions to speed up hough_circle#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the
hough_circlefunction to use several weird NumPy functions instead of iterating. This made it ~100x faster (my test event changed from 754 ms to 6.73 ms).The main differences are that it now only computes the differences between the points once, and it constructs
Hradin place rather than iterating over the thetas. The construction is done withnp.repeatandnp.tile. These functions (which I just discovered yesterday!) are different ways of repeating an array. So, for example,This appears to be much faster than looping in Python.