Skip to content

enable PIC for multi-versioned objects when targeting shared libraries #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ATTron merged 2 commits into from
Apr 15, 2026
Merged

enable PIC for multi-versioned objects when targeting shared libraries #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9628a
pic
0xroko Apr 7, 2026
0dd9c34
fix: tweak pic for macOS
ATTron Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ pub fn addMultiVersion(
/// creates a circular build dependency. Factor shared types into a
/// separate module instead.
imports: []const std.Build.Module.Import = &.{},
/// Force PIC on multi-versioned objects (for shared libraries).
pic: ?bool = null,
},
) void {
const b = compile.step.owner;
Expand Down Expand Up @@ -92,17 +94,20 @@ pub fn addMultiVersion(
query.cpu_model = .{ .explicit = cpuModelForLevel(level) };
const resolved = b.resolveTargetQuery(query);

const pic = options.pic orelse compile.root_module.pic;
const user_mod = b.createModule(.{
.root_source_file = options.source,
.target = resolved,
.optimize = compile.root_module.optimize orelse .Debug,
.pic = pic,
});
for (options.imports) |imp| user_mod.addImport(imp.name, imp.module);

const variant_mod = b.createModule(.{
.root_source_file = wrapper_source,
.target = resolved,
.optimize = compile.root_module.optimize orelse .Debug,
.pic = pic,
});
variant_mod.addImport("oma", oma_dep.module("oma"));
variant_mod.addImport("_oma_source", user_mod);
Expand Down