Conversation
- Rename Areas/ to Features/ and drop the "Area" suffix from subfolders (AdvancedSearchArea → AdvancedSearch, GraphArea → Graph, etc.) - Move scattered root-level feature folders (Ai, Analyzers, Export, Gallery, Help, Import, Project, Refactoring) into Features/ - Consolidate infrastructure into Shared/: - Converters/, Filter/, Wpf/ → Shared/ - Common/ split into Shared/Notifications/ and Shared/Search/ - Common/MessageBus → Shared/Messages/ - Common/Result → Shared/ - root Messages/ merged into Shared/Messages/ - Areas/Shared/ merged into Shared/UI/ - Update .csproj Page Update paths accordingly; remove stale Areas\TableArea\Templates reference Namespaces left unchanged intentionally — to be updated via ReSharper. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These types are pure data containers used in a cross-feature message (QuickInfoUpdateRequest). Keeping them in Features/Help caused an illegal Shared → Features dependency. QuickInfoFactory remains in Features/Help as it contains genuine feature logic (MSAGL graph objects → QuickInfo). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CodeExplorerControl (Features/Graph) was casting its DataContext to the concrete MainViewModel to call ClearQuickInfo(), creating an illegal Features → root dependency. - Add ClearQuickInfoRequest message to Shared/Messages/ - CodeExplorerControl.SetViewer now accepts IPublisher and publishes ClearQuickInfoRequest on empty-canvas mouse click - MainViewModel subscribes to ClearQuickInfoRequest in its constructor - Thread the IPublisher through MainWindow.SetViewer and App.xaml.cs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Move graph rendering constants to Features/Graph/Constants.cs (internal) - Inline TreeMinWidth* as private constants in MainWindow - Replace x:Static XAML bindings for TreeMinWidth* with literal values - Delete root Constants.cs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
XAML and code-behind now reference the same fields via {x:Static},
eliminating the risk of the two values drifting apart.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.