feat(triggers): Trigger System (Phase 2 Step 6)

[AVADSA25]

Summary

Phase 2 Step 6 — skills can declare patterns that auto-fire them when the observer (Step 5) detects a match. The infrastructure for ambient automation. Step 6 ships ZERO triggers — only the plumbing. Skills opt in one-by-one via SKILL_OBSERVATION_TRIGGER, same trust model as plugins.

Why this is safe

The May 1 incident was caused by skills firing without explicit user trigger. Step 6 is exactly that capability. Belt-and-braces:

• Default require_confirmation=True in design recommendations — opt-in to silent fires per-skill
• Default cooldown_seconds=600 in design recommendations — 10-min minimum between fires
• Destructive triggers route through Step 3 §1.7 strict-consent gate (literal verb-match, two-strike timeout)
• Per-trigger PWA kill switch + persistent ~/.codec/triggers_killed.json
• Global TRIGGERS_ENABLED=false env var disables the whole system
• Step 6 ships zero triggers — at merge, evaluate() iterates over zero registered triggers and exits in <1ms. Nothing fires.
• All fires go through codec_dispatch.run_skill — Step 2 run_with_hooks, Step 4 plugin observation, and Step 3 step budget all apply transparently.

Commits

sha	what
0ac7f39	docs/PHASE2-STEP6-DESIGN.md — full §0-§10 design
02a1bfb	Implementation: audit constants + codec_triggers.py + skill_registry ext + observer integration + 35 tests + PWA endpoints + AGENTS.md

Test plan

• pytest tests/test_triggers.py → 35/35 passing in 0.18s
• codec_dispatch.run_skill is mocked everywhere — NO real skills fired
• codec_ask_user.ask is mocked everywhere — never blocks on real threading.Event
• State files clean post-test: pending_questions=0, Apple Reminders=0, /tmp/codec_*.txt=0, triggers_killed.json absent
• Sanity: codec_audit.PHASE2_STEP6_EVENTS resolves; codec_triggers.evaluate is callable
• Per Step 4 contract: did NOT run full pytest suite

Test breakdown (35)

Area	Count	What it asserts
Trigger validation	5	All 5 required fields, key stability across reloads, key change on edit
Match per type	10	window_title / clipboard / file_change / time / compound (AND + OR)
Cooldown	5	Within window blocks, 0-cooldown ready, per-trigger independence, key-change resets, audit emit on cooldown block
Confirmation + destructive	8	Silent fire (confirm=False), confirm path approve/skip/timeout, destructive path verb-match/timeout, destructive overrides confirm
Kill switches + integration	7	Per-trigger kill silent skip + persistence, global TRIGGERS_ENABLED, observer.poll() calls evaluate(), skill_registry extracts SKILL_OBSERVATION_TRIGGER

§X Trigger flow

codec-observer poll loop
        │
        ▼
   evaluate(snapshot)
        │
        ├─ for each Trigger discovered from SkillRegistry:
        │     ├─ killed? → silent skip
        │     ├─ matches? → no, silent skip
        │     ├─ matches? → emit trigger_evaluated
        │     ├─ cooldown elapsed? → no, emit trigger_blocked
        │     │
        │     └─ destructive? → ask_user(destructive=True) — Step 3 §1.7
        │        require_confirmation? → ask_user(60s timeout, Approve/Skip)
        │        else → fire silently
        │
        ▼
   codec_dispatch.run_skill(skill, task=<rendered context>)
        │
        ▼ (existing chokepoint, hooks fire as usual)
   skill returns → emit trigger_fired

§6 Audit events (3 new)

Event	level	When
trigger_evaluated	info	A trigger's pattern matched (pre-cooldown / pre-consent)
trigger_fired	info	Skill actually invoked via dispatch
trigger_blocked	warning	Cooldown / confirmation reject / consent failure. block_reason ∈ {cooldown, user_skipped, confirmation_timeout, ambiguous_consent}. Killed reason intentionally NOT emitted.

What this PR does NOT do

• No _HTTP_BLOCKED change
• No new PM2 service — triggers run inline in codec-observer
• No skill ships with SKILL_OBSERVATION_TRIGGER — system is dormant at merge
• No ~/.codec/autopilot.json migration (it's empty {enabled: false, triggers: []})
• No Apple Reminders / Notes / Calendar entries

After merge

1. Pull main on local checkout.
2. pm2 restart codec-observer codec-dashboard — picks up the integration + PWA routes.
3. Verify with curl -H 'cookie: ...' http://127.0.0.1:8090/api/triggers → {"triggers": [], "global_enabled": true, "total": 0, "killed_count": 0} (empty list confirms zero registered).
4. To opt a skill in: edit the skill file, add SKILL_OBSERVATION_TRIGGER = {...}, restart codec-observer (rescan).

Phase 2 status after this PR

• ✅ Step 5 (Continuous Observation Loop) — merged via PR feat(observer): continuous observation loop (Phase 2 Step 5) #9 + hotfix fix(observer): ocr_enabled flag — bypass screencapture popup storm #10
• ✅ Step 6 (Trigger System) — THIS PR
• ⬜ Step 7 (Shift Report Crew) — final Phase 2 step

🤖 Generated with Claude Code