security: jsonstore Phase 2 — notifications RMW lock in scheduler + heartbeat#156
Merged
Conversation
…rtbeat (Fix #9 Phase 2) The dashboard / ask_user notifications writers hold codec_jsonstore.file_lock across their read-modify-write (Fix #5 / B-11), but the codec-scheduler and codec-heartbeat daemons wrote notifications.json directly (load→insert→json.dump) with no lock — so a scheduled-task or heartbeat-alert notification could clobber a concurrent dashboard write (and vice-versa). Both now hold file_lock(notif_path) across the whole RMW + use atomic_write_json. Every notifications.json writer is now serialized. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9 Phase 2. The dashboard + ask_user notifications writers already hold
codec_jsonstore.file_lockacross their read-modify-write (Fix #5 / B-11), but the codec-scheduler and codec-heartbeat daemons wrotenotifications.jsondirectly with no lock — racing/clobbering concurrent writes. Both now holdfile_lock(notif_path)across the load→insert→write + useatomic_write_json. Every notifications.json writer is now serialized.Tested:
codec_scheduler._notifyspy-asserts the flock is held + persists atomically; notification/state suites green (19); ruff clean.🤖 Generated with Claude Code