Bug/1010 reference counting issue spice interface #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
previously requested changes
Jun 9, 2025
Natsoulas
force-pushed
the
bug/1010-reference-counting-issue-spice-interface
branch
from
4be8824 to
8f24ffd
Compare
Natsoulas
force-pushed
the
bug/1010-reference-counting-issue-spice-interface
branch
from
8f24ffd to
79c638b
Compare
Contributor
|
@Mark2000 , I'll let you do final reviews of this PR while I'm on travel. |
Mark2000
approved these changes
Jun 10, 2025
Contributor
Mark2000
left a comment
Mark2000
left a comment
There was a problem hiding this comment.
Verified that this fixes the bug I was encountering. Thanks for the quick fix @Natsoulas
Contributor
Author
|
Sweet glad the spiceInterface issues saga I brought on is almost over. Could you rerun the tests that timed out? I'm afk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REQUIRED_KERNELS#1010Description
Fixed reference counting issue with SpiceInterface REQUIRED_KERNELS that was causing SPICE(NOLEAPSECONDS) errors in multi-instance scenarios. Added global reference counting for required kernels. Made kernel unloading more robust by using exact filename matching and ensuring required kernels stay loaded as long as any instance needs them.
Verification
Unit tests pass locally.
Requires further verification with BSK-RL by @Mark2000
Documentation
Updated release notes describing fix briefly.
Future work
Track and resolve any further issues with spiceInterface class.