-
Notifications
You must be signed in to change notification settings - Fork 91
Support 1DOF hingedPanel branching with dynamic effectors #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb08784 to
283fab3
Compare
283fab3 to
688c16e
Compare
19970f5 to
39d28ed
Compare
39d28ed to
263c40e
Compare
schaubh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Some small things to address with my comments.
The integrated test, however, is regularly failing on my computer.
src/simulation/dynamics/HingedRigidBodies/hingedRigidBodyStateEffector.h
Outdated
Show resolved
Hide resolved
src/simulation/dynamics/HingedRigidBodies/hingedRigidBodyStateEffector.i
Show resolved
Hide resolved
src/simulation/dynamics/HingedRigidBodies/hingedRigidBodyStateEffector.cpp
Outdated
Show resolved
Hide resolved
...mulation/dynamics/_GeneralModuleFiles/_UnitTestDynamics/test_effectorBranching_integrated.py
Outdated
Show resolved
Hide resolved
ca3d33c to
7b5855a
Compare
e45402c to
1cbe641
Compare
|
Ran into a strange merge phenomenon and decided to throw in the towel on recovering this branch. Relevant commits are cherry picked to new branch which is now using PR #1179. |
Description
That adds support for 1DOF Hinged Rigid Body State Effector to be the parent for Dynamic Effectors
Verification
Used hinged rigid body state effector properties to calculate the angular momentum and delta v and compared it to the modified equations of motion output angular momentum and delta v in test_effectorBranching_integrated.py and plots them against each other to verify dynamics. Additionally, a scenario with 5 different spacecraft was written and compared plotted dynamics variables to intuitive values and behaviors. One spacecraft exhibited natural dynamics. Two were enacted on by external force and an additional two were enacted on by external torque. The force and torque were located on the hub and on the hinged rigid body state effector for each.
Documentation
Added a note to
docs/source/Support/bskReleaseNotes.rst. Changed the yellow cells associated with 1DOF HRB to green inbskPrinciples-11.rst. Occasional lines of RST documentation embedded throughout certain scripts using //!< in header file variable definitions, or /*! */ just before method definitions in cpp files. These show up in pages like https://avslab.github.io/basilisk/Documentation/simulation/dynamics/HingedRigidBodies/hingedRigidBodyStateEffector.html at the end of the file after the documentation generated by the standalone .rst file.Future work
2DOF HRB and NDOF HRB augmented to support dynamic effectors.