Conversation
dhutererprats
approved these changes
May 5, 2025
Contributor
dhutererprats
left a comment
dhutererprats
left a comment
There was a problem hiding this comment.
Looks good. Now both float32 and float 64 will be compatible as observation data types.
Mark2000
force-pushed
the
bugfix/dtypes
branch
3 times, most recently
from
91984b3 to
a965f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #254
Allows for specification of observation dtype.
Type of change
How should this pull request be reviewed?
Checklist