Skip to content

[MINOR] Reenable notebooks#280

Merged
Mark2000 merged 1 commit intodevelopfrom
bugfix/bsk-build
Jun 17, 2025
Merged

[MINOR] Reenable notebooks#280
Mark2000 merged 1 commit intodevelopfrom
bugfix/bsk-build

Conversation

@Mark2000
Copy link
Copy Markdown
Contributor

@Mark2000 Mark2000 commented Jun 17, 2025

Description

Seems like the CI decided to start working again?

Copilot AI review requested due to automatic review settings June 17, 2025 15:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables notebook functionality by reactivating tests and updating associated documentation and configuration files. Key changes include:

  • Re-enabling the previously skipped test in tests/unittest/utils/test_orbital.py.
  • Removing outdated warning documentation regarding notebook builds in examples/_default.rst.
  • Updating documentation configuration in docs/source/conf.py by commenting out the nbsphinx_execute setting.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/unittest/utils/test_orbital.py Removal of the skip decorator to re-enable tests
examples/_default.rst Removal of the warning block related to notebook build issues
docs/source/conf.py Commenting out nbsphinx_execute configuration as a temporary measure
Comments suppressed due to low confidence (3)

examples/_default.rst:2

  • Since the warning block for notebook builds has been removed, please update the documentation to clearly reflect the current support status of notebooks.
========

docs/source/conf.py:57

  • [nitpick] If the nbsphinx_execute setting is no longer necessary, consider removing the commented-out line altogether to maintain a clean configuration file.
# nbsphinx_execute = "never"

tests/unittest/utils/test_orbital.py:208

  • [nitpick] The removal of the skip marker is intentional; however, ensure that any intermittent failures specific to the GitHub environment have been addressed or consider using conditional skips to prevent test flakiness.
        )

Copy link
Copy Markdown
Contributor

@LorenzzoQM LorenzzoQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the CI will stay happy and working.

@Mark2000 Mark2000 merged commit 3f21723 into develop Jun 17, 2025
5 checks passed
@Mark2000 Mark2000 deleted the bugfix/bsk-build branch June 17, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants