Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables notebook functionality by reactivating tests and updating associated documentation and configuration files. Key changes include:
- Re-enabling the previously skipped test in tests/unittest/utils/test_orbital.py.
- Removing outdated warning documentation regarding notebook builds in examples/_default.rst.
- Updating documentation configuration in docs/source/conf.py by commenting out the nbsphinx_execute setting.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/unittest/utils/test_orbital.py | Removal of the skip decorator to re-enable tests |
| examples/_default.rst | Removal of the warning block related to notebook build issues |
| docs/source/conf.py | Commenting out nbsphinx_execute configuration as a temporary measure |
Comments suppressed due to low confidence (3)
examples/_default.rst:2
- Since the warning block for notebook builds has been removed, please update the documentation to clearly reflect the current support status of notebooks.
========
docs/source/conf.py:57
- [nitpick] If the nbsphinx_execute setting is no longer necessary, consider removing the commented-out line altogether to maintain a clean configuration file.
# nbsphinx_execute = "never"
tests/unittest/utils/test_orbital.py:208
- [nitpick] The removal of the skip marker is intentional; however, ensure that any intermittent failures specific to the GitHub environment have been addressed or consider using conditional skips to prevent test flakiness.
)
LorenzzoQM
approved these changes
Jun 17, 2025
Contributor
LorenzzoQM
left a comment
There was a problem hiding this comment.
Hopefully the CI will stay happy and working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Seems like the CI decided to start working again?