feat: dynamic typealias for non-String inline schemas by halotukozak · Pull Request #19 · AVSystem/justworks

halotukozak · 2026-03-20T13:05:29Z

Summary

Add underlyingType: TypeRef? field to SchemaModel — parser fills it for primitive-only schemas via toTypeRef()
Generator uses TypeMapping.toTypeName() for dynamic type resolution instead of hardcoded STRING
Supports: Int, Long, Double, Float, Boolean, ByteArray, List, and reference wrappers
UUID typealias will work automatically once PR feat: extend format-to-type mapping with UUID support #17 merges (adds PrimitiveType.UUID)

Test plan

7 new typealias tests: Int, Boolean, Long, Double, Array, Reference, String regression
./gradlew :core:test passes

🤖 Generated with Claude Code

- Test Int, Boolean, Long, Double, Array, and Reference underlying types - Update existing String test with explicit type assertion and underlyingType = null - Tests fail to compile until underlyingType field is added to SchemaModel Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Add underlyingType: TypeRef? field to SchemaModel with null default - Parser computes underlyingType via toTypeRef() for primitive-only schemas - Generator uses TypeMapping.toTypeName() to resolve dynamic target type - Fallback to String when underlyingType is null (backward compatible) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-20T13:07:45Z

Overall Project	93.38% `-0.03%`	🍏
Files changed	97.5%	🍏

File	Coverage
ApiSpec.kt	99.28%	🍏
ModelGenerator.kt	94.72%	🍏
SpecParser.kt	88.96% `-0.1%`	🍏

Copilot

Pull request overview

Adds support for generating typealiases to non-String Kotlin types when an OpenAPI schema is “primitive-only” (no properties / compositors), by carrying resolved schema type information from parsing into model generation.

Changes:

Extend SchemaModel with underlyingType: TypeRef? to represent the resolved underlying schema type for primitive-only schemas.
Populate underlyingType in SpecParser and use it in ModelGenerator (via TypeMapping.toTypeName) when generating typealiases.
Expand ModelGeneratorTest coverage with additional typealias assertions for multiple primitive/collection/reference cases.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
core/src/main/kotlin/com/avsystem/justworks/core/model/ApiSpec.kt	Adds `underlyingType` to `SchemaModel` to carry primitive-only schema type info.
core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt	Attempts to infer and set `underlyingType` for primitive-only / wrapper schemas during parsing.
core/src/main/kotlin/com/avsystem/justworks/core/gen/ModelGenerator.kt	Uses `underlyingType` (mapped through `TypeMapping`) to generate typealiases to dynamic Kotlin types.
core/src/test/kotlin/com/avsystem/justworks/core/gen/ModelGeneratorTest.kt	Adds/updates tests asserting generated typealias targets across multiple underlying types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt

core/src/main/kotlin/com/avsystem/justworks/core/gen/ModelGenerator.kt

core/src/test/kotlin/com/avsystem/justworks/core/gen/ModelGeneratorTest.kt

- Streamline conditions for determining schema's underlying type - Avoid assigning invalid TypeRef instances in edge cases

github-actions · 2026-03-20T13:54:52Z

Overall Project	93.38% `-0.05%`	🍏
Files changed	96.33%	🍏

File	Coverage
ApiSpec.kt	99.28%	🍏
ModelGenerator.kt	94.72%	🍏
SpecParser.kt	89.01% `-0.2%`	🍏

github-actions · 2026-03-20T13:55:24Z

Overall Project	93.38% `-0.05%`	🍏
Files changed	96.33%	🍏

File	Coverage
ApiSpec.kt	99.28%	🍏
ModelGenerator.kt	94.72%	🍏
SpecParser.kt	89.01% `-0.2%`	🍏

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt

…tion toTypeRef() resolves component schemas to self-referential TypeRef.Reference via componentSchemaIdentity, making underlyingType always null for primitive-only schemas. Extract resolveByType() to resolve structurally from type/format, and use it directly for underlyingType while still honoring $ref for wrappers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt

Remove unreachable allOf single-ref branch from underlyingType resolution (isPrimitiveOnly requires allOf == null). Reformat to satisfy ktlint newline-before-?. rules. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-20T14:16:31Z

Overall Project	93.43% `-0.51%`	🍏
Files changed	87.03%	🍏

File	Coverage
ApiSpec.kt	99.28%	🍏
ModelGenerator.kt	94.72%	🍏
SpecParser.kt	89.22% `-1.85%`	🍏

github-actions · 2026-03-20T14:18:02Z

Overall Project	93.23% `-0.72%`	🍏
Files changed	82.35%	🍏

File	Coverage
ApiSpec.kt	99.28%	🍏
ModelGenerator.kt	94.72%	🍏
SpecParser.kt	88.52% `-2.62%`	🍏

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt

- Add test cases for primitive, array, reference, object, and allOf schemas - Ensure proper behavior of underlyingType in various schema scenarios - Extend SpecParserTest to cover edge cases and validate correctness

halotukozak and others added 2 commits March 20, 2026 13:50

Copilot AI review requested due to automatic review settings March 20, 2026 13:05

Copilot started reviewing on behalf of halotukozak March 20, 2026 13:05 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

halotukozak and others added 2 commits March 20, 2026 14:52

refactor(parser): simplify underlyingType resolution logic

dd381bf

- Streamline conditions for determining schema's underlying type - Avoid assigning invalid TypeRef instances in edge cases

Merge branch 'master' into feat/typealias-non-string-primitives

b806066

halotukozak requested a review from Copilot March 20, 2026 13:53

Copilot started reviewing on behalf of halotukozak March 20, 2026 13:53 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt Outdated Show resolved Hide resolved

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt Outdated Show resolved Hide resolved

halotukozak requested a review from Copilot March 20, 2026 14:03

Copilot started reviewing on behalf of halotukozak March 20, 2026 14:04 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt Outdated Show resolved Hide resolved

halotukozak self-assigned this Mar 20, 2026

halotukozak and others added 2 commits March 20, 2026 15:14

style: use takeIf chain for underlyingType resolution

066a6a4

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

halotukozak requested a review from MattK97 March 20, 2026 14:36

MattK97 requested changes Mar 23, 2026

View reviewed changes

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt Show resolved Hide resolved

core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt Show resolved Hide resolved

test(parser): add unit tests for underlyingType resolution

7be8f8c

- Add test cases for primitive, array, reference, object, and allOf schemas - Ensure proper behavior of underlyingType in various schema scenarios - Extend SpecParserTest to cover edge cases and validate correctness

halotukozak requested a review from MattK97 March 23, 2026 09:43

Merge branch 'master' into feat/typealias-non-string-primitives

003cf74

MattK97 approved these changes Mar 23, 2026

View reviewed changes

halotukozak merged commit dec23c9 into master Mar 23, 2026
1 check failed

halotukozak deleted the feat/typealias-non-string-primitives branch March 23, 2026 10:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: dynamic typealias for non-String inline schemas#19

feat: dynamic typealias for non-String inline schemas#19
halotukozak merged 9 commits intomasterfrom
feat/typealias-non-string-primitives

halotukozak commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

halotukozak commented Mar 20, 2026

Summary

Test plan

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants