-
Notifications
You must be signed in to change notification settings - Fork 2
Implement Autopilot for drive-to-pose functionality #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: vendordeps/Autopilot.json
new file: src/main/java/frc/robot/AprilTagLayout.java modified: src/main/java/frc/robot/Constants.java modified: src/main/java/frc/robot/RobotContainer.java modified: src/main/java/frc/robot/subsystems/vision/Vision.java modified: src/main/java/frc/robot/subsystems/vision/VisionIOPhotonVision.java modified: src/main/java/frc/robot/subsystems/vision/VisionIOPhotonVisionSim.java
Update the drivebase constants PID values with those used for the FRC-2486 2025 competition bot. These were SDS Mk4i w/ Kraken X60's, so should be somewhat close for most robot projects.
The class constructors and command factory for the Autopilot drive-to-pose framework is in place. The next steps will be to define targets and be able to modify drive-to-pose configurations as needed by specific commands.
Included documentation in code about how to use AutoPilot in the RobotContainer class.
Send a supplier for the accelerometer rather than the accelerometer object itself.
The URCL library was causing crashing when trying to test code on the robot. Temporarily removing it to allow for on-robot testing of the rest of the code base.
Previous implementation was double-sampling the PDM because AKit was reading everything and then this module was reading it again. At the moment, power logging is not working at all (even from AKit), but this may be a bug I fixed from 26-beta1 and it will be fine with the kickoff release.
Still not working. The Commands.run() bit is just not being executed. Updated ModuleIOTalonFX.java and ModuleIOTalonFXS.java to match FRC2486's in-season use of those modules.
Use the Commands.defer() construct. Also, include the PID-reset and until parts of the AutoPilot command.
2fdfce3 to
6938b03
Compare
Collaborator
Author
|
Closes #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Autopilot library for drive-to-pose functionality.