Make No Delete Mode robust against Cut and Selection Replacement #4
Conversation
- Handle `beforeinput` events for `deleteContentBackward` and `deleteContentForward` to support mobile/virtual keyboards. - Prevent text replacement when selecting text and typing (overwriting selection). - Add `onCut` handler to prevent cutting text. - Synchronize shake animation duration to 400ms to match CSS. - Ensure toast notifications appear for all blocked actions. Co-authored-by: Aarekaz <36888347+Aarekaz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Enhanced the "No Delete Mode" in
app/page.tsxto be more robust. Previously, it only handled Backspace/Delete keys viakeydown, which missed several ways to delete text (e.g., cutting, replacing selection, mobile inputs).Changes:
handleBeforeInputto listen for nativeInputEventtypes:deleteContentBackward,deleteContentForward.insert*events when a text selection exists (replacing text).onCuthandler totextareato block cut operations.PR created automatically by Jules for task 8265703141049236614 started by @Aarekaz