Merged
Conversation
- Updated LibraryDrawerContent.kt to replace hardcoded colors with MaterialTheme colors for better consistency and theming. - Enhanced ReaderScreen.kt by integrating MaterialTheme colors and adding support for dynamic theming based on user preferences. - Improved ExploreScreen.kt by implementing MaterialTheme colors and adding a skeleton loading card for better user experience during data fetching. - Adjusted Theme.kt to enable dynamic colors and set status/navigation bar colors based on the current theme. - Modified ReaderViewModel.kt to include reader theme management, allowing users to switch themes seamlessly.
…ncy injection; update LibraryRepository tests to mock LibraryDao; enhance build configuration with Hilt, KSP, and Kotlin serialization; update dependencies in libs.versions.toml for improved functionality and compatibility.
…ving image handling, and refining progress tracking
… ReaderImageView and ReaderScreen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several major infrastructure improvements and refactors to the project, focusing on dependency management, DI setup, navigation, and codebase modernization. The most significant changes are the adoption of Hilt for dependency injection, migration to Room for local data storage, refactoring of
MainActivityto leverage injected dependencies and navigation, and updates to build and ProGuard configurations to support these new libraries.Dependency Injection & Project Infrastructure
MainActivityand the newEasyReaderApplicationclass. (app/build.gradle.kts,app/src/main/AndroidManifest.xml,app/src/main/java/io/aatricks/novelscraper/EasyReaderApplication.kt,app/src/main/java/io/aatricks/novelscraper/MainActivity.kt) [1] [2] [3] [4]Database & Serialization
AppDatabasewith a DAO forLibraryItem. (app/build.gradle.kts,app/src/main/java/io/aatricks/novelscraper/data/local/AppDatabase.kt) [1] [2]app/build.gradle.kts,app/proguard-rules.pro) [1] [2]Navigation & UI Refactor
MainActivityto useNavHostand injected ViewModels, and updated screen composition logic. (app/build.gradle.kts,app/src/main/java/io/aatricks/novelscraper/MainActivity.kt) [1] [2]Build System & Dependency Management
build.gradle.ktsto use version catalog (libs.*) for all major dependencies, added plugins for Hilt, KSP, and Kotlin serialization, and reorganized dependencies for clarity and maintainability. (app/build.gradle.kts) [1] [2]ProGuard Configuration
app/proguard-rules.pro)