🔒 Fix Intent URL Validation & SSRF Vulnerability#32
Conversation
… confirmation - Remove automatic library addition for external `ACTION_VIEW` intents. - Implement `UrlSecurity` to block private IPs and non-HTTP schemes (SSRF mitigation). - Add `ExternalUrlConfirmationDialog` to prompt user consent before loading external links. - Hoist dialog state to `MainActivity` to ensure visibility regardless of current screen. - Update `ReaderViewModel` to manage external URL request state. Co-authored-by: Aatricks <113598245+Aatricks@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Aatricks
deleted the
security/intent-url-validation-862430617499026646
branch
1 participant
This PR addresses a security vulnerability where
MainActivityblindly accepted and scraped URLs viaACTION_VIEWintents, potentially allowing malicious apps to pollute the library or trigger SSRF attacks by pointing the scraper to local network resources.Changes:
UrlSecurityutility to reject private IP addresses (192.168.x.x, 10.x.x.x, etc.) and loopback addresses, ensuring the scraper only targets public web content.ExternalUrlConfirmationDialog. When an external link is received, the app now prompts the user ("Open this link in Reader?") instead of acting immediately.libraryViewModel.addIteminMainActivity. External links are now opened in "Preview Mode" and are not automatically saved to the persistent library database, preventing library pollution.MainActivity(Compose root) to ensure the dialog is visible even if the user was on a different screen (e.g., Explore) when the intent was received. Upon confirmation, the app navigates to theReaderScreen.UrlSecurityTestto verify IP blocking logic.PR created automatically by Jules for task 862430617499026646 started by @Aatricks