Skip to content

⚡ Limit concurrency in NovelFireSource to prevent rate limiting#40

Merged
Aatricks merged 1 commit intomainfrom
novelfire-concurrency-fix-3166179376735314383
Feb 13, 2026
Merged

⚡ Limit concurrency in NovelFireSource to prevent rate limiting#40
Aatricks merged 1 commit intomainfrom
novelfire-concurrency-fix-3166179376735314383

Conversation

@Aatricks
Copy link
Owner

💡 What:

  • Implemented Semaphore(3) in NovelFireSource.loadAdditionalChapterPages to limit concurrent network requests.
  • Added NovelFireSourceConcurrencyTest to verify the concurrency limit using a mocked OkHttpClient interceptor.

🎯 Why:

  • Previously, loadAdditionalChapterPages would spawn a coroutine for every page (2..maxPage) simultaneously. For novels with many pages, this resulted in a burst of requests (unbounded concurrency) which could overwhelm the server or the client's network stack.
  • Limiting concurrency to 3 ensures a steady, respectful flow of requests.

📊 Measured Improvement:

  • Baseline: NovelFireSourceConcurrencyTest showed a max concurrency of 9 for a 10-page novel (all pages requested at once).
  • Optimized: NovelFireSourceConcurrencyTest confirms max concurrency is now limited to <= 5 (specifically constrained by Semaphore(3)).

PR created automatically by Jules for task 3166179376735314383 started by @Aatricks

Introduced a `Semaphore` with 3 permits to restrict the number of concurrent network requests when loading additional chapter pages in `NovelFireSource`. This prevents unbounded concurrency which could lead to server rate limiting or resource exhaustion.

Verified with `NovelFireSourceConcurrencyTest`.

Co-authored-by: Aatricks <113598245+Aatricks@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Aatricks Aatricks merged commit 038ba5a into main Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant