Conversation
Introduced a `Semaphore` with 3 permits to restrict the number of concurrent network requests when loading additional chapter pages in `NovelFireSource`. This prevents unbounded concurrency which could lead to server rate limiting or resource exhaustion. Verified with `NovelFireSourceConcurrencyTest`. Co-authored-by: Aatricks <113598245+Aatricks@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Semaphore(3)inNovelFireSource.loadAdditionalChapterPagesto limit concurrent network requests.NovelFireSourceConcurrencyTestto verify the concurrency limit using a mockedOkHttpClientinterceptor.🎯 Why:
loadAdditionalChapterPageswould spawn a coroutine for every page (2..maxPage) simultaneously. For novels with many pages, this resulted in a burst of requests (unbounded concurrency) which could overwhelm the server or the client's network stack.📊 Measured Improvement:
NovelFireSourceConcurrencyTestshowed a max concurrency of 9 for a 10-page novel (all pages requested at once).NovelFireSourceConcurrencyTestconfirms max concurrency is now limited to <= 5 (specifically constrained bySemaphore(3)).PR created automatically by Jules for task 3166179376735314383 started by @Aatricks