Skip to content

Dynamic Width Scaling in Condition Encoding#14

Merged
Aatricks merged 1 commit intomainfrom
cond-dynamic-width-scaling-451456543888025473
Jan 10, 2026
Merged

Dynamic Width Scaling in Condition Encoding#14
Aatricks merged 1 commit intomainfrom
cond-dynamic-width-scaling-451456543888025473

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

Implements dynamic retrieval of the downscale factor from the model configuration in encode_model_conds instead of using a hardcoded value of 8.

Changes:

  • Added downscale_factor attribute to LatentFormat class in src/Utilities/Latent.py (default: 8).
  • Modified src/cond/cond.py to retrieve downscale_factor from model.latent_format if available, falling back to 8.
  • Verified with a reproduction script that mocks the model and latent format.

PR created automatically by Jules for task 451456543888025473 started by @Aatricks

…model config

Replaced the hardcoded multiplier of 8 for default width/height calculation in `src/cond/cond.py` with a value retrieved from the model's `LatentFormat`. Added `downscale_factor` to `LatentFormat` in `src/Utilities/Latent.py` with a default of 8 to maintain backward compatibility. This allows models with different VAE compression ratios to be supported correctly.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Aatricks Aatricks self-assigned this Jan 10, 2026
@Aatricks Aatricks marked this pull request as ready for review January 10, 2026 19:52
@Aatricks Aatricks merged commit 625ac6f into main Jan 10, 2026
1 check failed
@Aatricks Aatricks deleted the cond-dynamic-width-scaling-451456543888025473 branch January 10, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant