Skip to content

Avoid unnecessary GGUF model unloading after patches#16

Merged
Aatricks merged 1 commit intomainfrom
jules/fix-gguf-unload-7709232856346694567
Jan 10, 2026
Merged

Avoid unnecessary GGUF model unloading after patches#16
Aatricks merged 1 commit intomainfrom
jules/fix-gguf-unload-7709232856346694567

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

Implemented logic in GGUFModelPatcher.unpatch_model to check src.Device.current_loaded_models. If the model is not in the list (meaning it was popped for reload/repatch), the method ignores the device_to argument if it points to the offload device, thus preserving the weights on the current device (GPU). This avoids the expensive GPU->CPU transfer when simply changing LoRAs or patches.


PR created automatically by Jules for task 7709232856346694567 started by @Aatricks

Prevent unloading GGUF model weights to CPU during unpatching when the model is not scheduled for full unload (i.e., not in `current_loaded_models`). This allows faster patch switching by keeping base weights on GPU.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Aatricks Aatricks self-assigned this Jan 10, 2026
@Aatricks Aatricks marked this pull request as ready for review January 10, 2026 19:52
@Aatricks Aatricks merged commit e320f3b into main Jan 10, 2026
1 check failed
@Aatricks Aatricks deleted the jules/fix-gguf-unload-7709232856346694567 branch January 10, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant