Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes across the codebase, focusing on enhanced batch conditioning support, improved robustness when optional dependencies are missing, and better file management and user documentation. The most significant changes are summarized below.
Batch Conditioning and Compatibility Improvements:
CLIPTextEncode.encodeinsrc/clip/Clip.pyto support encoding a list of prompts, returning results in a backward-compatible format for both single and batch prompt scenarios.convert_condandcalc_cond_batchinsrc/cond/cond.pyto robustly handle both legacy and new condition formats, support batch processing with per-chunk timestep alignment, and provide optional debug logging for batch issues. [1] [2] [3]Robustness and Fallbacks for Optional Dependencies:
gen_stable_fast_configandApplyStableFastUnet.apply_stable_fastinsrc/StableFast/StableFast.pyto gracefully handle missing optionalsfastdependencies, ensuring the application continues to function with conservative defaults and clear logging. [1] [2]File Management and Metadata:
save_imagesinsrc/FileManaging/ImageSaver.pyto return the actual subfolder path relative to./outputand include the originally requested subfolder, improving traceability and file location for callers. [1] [2]Documentation and User Guidance:
README.mdto add a note instructing users to manually download the FLUX VAE model due to its gated status on Huggingface, clarifying setup steps for new users.Miscellaneous:
osandlogginginsrc/cond/cond.pyfor new functionality.generate_noiseinsrc/AutoDetailer/ADetailer.pyto explicitly passseeds_per_sample=Nonefor improved clarity and future compatibility.