Skip to content

Add support for Scala 2.13#160

Open
petr-pokorny-absa wants to merge 2 commits intomasterfrom
support-scala-2.13
Open

Add support for Scala 2.13#160
petr-pokorny-absa wants to merge 2 commits intomasterfrom
support-scala-2.13

Conversation

@petr-pokorny-absa
Copy link
Copy Markdown

This pull request adds support for Scala 2.13 across the project, updating documentation, build configuration, and dependency handling to ensure compatibility. It also updates some dependency versions and cleans up test and example configurations.

Scala 2.13 support and dependency updates:

  • Updated project/Dependencies.scala to support Scala 2.13 in dependency resolution, including Spark, json4s, and Jackson modules. Added new version constants for Scala 2.13 and improved helper functions to handle three Scala versions. Also updated the absaCommons dependency version. [1] [2]
  • Updated the README.md to document usage and dependency examples for Scala 2.13, including for core, S3 extension, json4s, and model modules. [1] [2] [3] [4]

Build and test configuration:

  • Upgraded sbt version in project/build.properties from 1.5.5 to 1.9.9 for better Scala 2.13 support.
  • Modified test regex patterns in BuildPropertiesSpec.scala and ControlMeasureBuilderTest.scala to accept Scala 2.13 artifact names. [1] [2] [3]
  • Changed the Mockito mock maker configuration in test resources to use SubclassByteBuddyMockMaker instead of mock-maker-inline, likely for better compatibility.

Cleanup and simplification:

  • Removed unused or redundant imports and dependencies from the example and test configurations, including dropping specs2 in favor of scalatest for examples. [1] [2] [3]

@github-actions
Copy link
Copy Markdown

JaCoCo code coverage report - scala:2.12.15

Overall Project 52.77% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link
Copy Markdown

JaCoCo code coverage report - scala:2.11.12

Overall Project 47.62% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link
Copy Markdown

JaCoCo code coverage report - scala:2.13.14

Overall Project 49.91% 🍏

There is no coverage information present for the Files changed

Copy link
Copy Markdown
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I like the changes, it's pretty expected. Interested in that CI failures behind cache GH Action though. But I would start with this: version used here is extra old, it's v5. Just try to update it and let's see what happens:

https://github.com/coursier/cache-action/releases/tag/v8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants