Skip to content

#83 jackson serialization support #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dk1844 merged 1 commit into from
Jun 9, 2021
Merged

#83 jackson serialization support #84

dk1844 merged 1 commit into from
Jun 9, 2021

Conversation

@dk1844
Copy link
Collaborator

@dk1844 dk1844 commented Jun 3, 2021 •
edited
Loading

Jackson serialization support was added for RunStatus (contains a field of RunState enum type)

  • unit test cases for this has been added

  • discussion point - Breaking-compatibility-wise, should this be introduced as part of Atum 4?

Test-run

  • Manually tested in Enceladus (2.x @ Scala 2.11), Enceladus (3.x @ Scala 2.12) using a local snapshot dependency, namely in commit 7f2d6e55324514b7f4093f260d20091559ab4f09 (branch develop-ver-3.0).
    • originally, the test passes with this JSON value:
     "runStatus": {
   "status": {
     "enumClass": "za.co.absa.atum.model.RunState",
     "value": "allSucceeded"
   },
   "error": null
 },
    • after using this Atum snapshot, the test passes with:
      "runStatus": {
    "status": "allSucceeded",
    "error": null
  },

Closes #83.

@dk1844 dk1844 marked this pull request as ready for review June 3, 2021 14:39
@dk1844 dk1844 requested a review from Zejnilovic June 3, 2021 14:39
@dk1844
#83 jackson serialization support was added for RunStatus (contains f…
1470398 
…ield of RunState enum)

 - unit test cases for this has been added
@dk1844 dk1844 force-pushed the feature/83-jackson-enum-support branch from 63cc447 to 1470398 Compare June 3, 2021 14:42
Zejnilovic
Zejnilovic approved these changes Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@Zejnilovic Zejnilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for this to be merged into branch release/4.0.0

Regarding the failing Spark 3. I did try a few things around and failed on all of them. Also, I am not sure why this is the only place where it is failing. Even across other projects. 🤷‍♂️

@dk1844 dk1844 changed the base branch from master to release/4.0.0 June 7, 2021 14:39
@dk1844 dk1844 merged commit c092cdc into release/4.0.0 Jun 9, 2021
@dk1844 dk1844 deleted the feature/83-jackson-enum-support branch June 9, 2021 13:19
@dk1844 dk1844 mentioned this pull request May 20, 2022
Closed
dk1844 added a commit that referenced this pull request May 20, 2022
@dk1844
#131 jackson serialization support was added for RunStatus (contains …
98cb4cf 
…field of RunState enum) (CP'd from PR #84)

- unit test cases for this has been added
@dk1844 dk1844 mentioned this pull request May 20, 2022
Merged
dk1844 added a commit that referenced this pull request May 26, 2022
@dk1844
#131 Backport of jackson serialization support (RunStatus enum) (#132)
ec84511 
* #131 jackson serialization support was added for RunStatus (contains field of RunState enum) (CP'd from PR #84)
- unit test cases for this has been added
* sbt: jackson-databind added (otherwise default v2.8.4 kicks in and it is incompatible)
* sbt-dependencies mirroring maven dependencies - exclusions, too.
@dk1844 dk1844 mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zejnilovic Zejnilovic Zejnilovic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RunState enums serialization differs between json4s and jackson.databind

3 participants

@dk1844 @Zejnilovic