Fix a11y issues in file upload component#547
Merged
Conversation
Coverage report for library
Test suite run success453 tests passing in 22 suites. Report generated by 🧪jest coverage report action from 33f9f83 |
Playwright test resultsDetails
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses accessibility gaps in the cps-file-upload component by improving its accessible name/disabled behavior, adding clearer processing/error UX, and enabling automated a11y scanning for the component page.
Changes:
- Adds accessibility and UX enhancements to
cps-file-upload(aria label, disabled state, keyboard interactions, error feedback, processing lifecycle events). - Updates styling for clearer focus/disabled/error states and rem-based sizing.
- Enables Playwright axe scans for the file upload page and updates composition examples/docs data accordingly.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/cps-ui-kit/src/lib/components/cps-progress-linear/cps-progress-linear.component.ts | Recomputes resolved colors on input changes for dynamic theme/token updates. |
| projects/cps-ui-kit/src/lib/components/cps-file-upload/cps-file-upload.component.ts | Adds new inputs/outputs and drag/drop + processing/error state handling. |
| projects/cps-ui-kit/src/lib/components/cps-file-upload/cps-file-upload.component.html | Improves semantics (button), live announcements, disabled/processing UI, and keyboard removal action. |
| projects/cps-ui-kit/src/lib/components/cps-file-upload/cps-file-upload.component.scss | Adds focus ring, disabled/error styling, and rem-based sizing updates. |
| projects/composition/src/app/pages/file-upload-page/file-upload-page.component.ts | Updates demo logic to exercise new events, disable toggling, and state reset on extension changes. |
| projects/composition/src/app/pages/file-upload-page/file-upload-page.component.scss | Adds layout styling for the new demo sections. |
| projects/composition/src/app/pages/file-upload-page/file-upload-page.component.html | Expands examples to include aria label, disabled state, and processing events; updates sizing units. |
| projects/composition/src/app/pages/divider-page/divider-page.component.scss | Aligns section title color with updated design token usage. |
| projects/composition/src/app/api-data/cps-file-upload.json | Documents new ariaLabel, disabled, fileProcessed, and fileProcessingFailed API surface. |
| playwright/cps-accessibility.spec.ts | Enables axe scanning for the file upload route/component. |
lukasmatta
reviewed
Apr 24, 2026
lukasmatta
reviewed
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing accessibility issues in file upload component
Validation rules:
Validated using Playwright accessibility tests, Lighthouse tool, axe DevTools extension, Accessibility Insights for Web extension, and manual checks including keyboard tab navigation and screen reader testing.
Full doc with rules
Playwright axe-core validation results:
State before:
State after:
Checklist
Keyboard Navigation
All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.
Focus Management
Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.
Semantics / ARIA
Color / Contrast
Screen Reader / Assistive Technology
Responsive & Zoom
Error Handling
Dynamic Content / Updates
Interaction Feedback / States
[N/A] Authentication & Sensitive Actions
Predictable & Controllable UI
Release notes: