-
Notifications
You must be signed in to change notification settings - Fork 0
Separating db engine and core #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
benedeki
commented
Feb 4, 2022
- Separated the core and the Slick implementation
- Core is now independent and type-parametrized
- Enceladus moved to examples folder
- Deleted all kind unneeded code
* Removed some unnecessary classes * Project fixes
* Clearer placement for NamingConventions implicits
|
This might be easier to review as the whole code rather than a PR with code compare. /methinks |
Co-authored-by: Saša Zejnilović <zejnils@gmail.com>
dk1844
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just read the code). To the degree that I have understood it, I see nothing wrong.
* fixed typo
# Conflicts: # src/main/scala/za/co/absa/faDB/DBFunction.scala
| */ | ||
|
|
||
| package za.co.absa.faDB.namingConventions.lettersCase | ||
| package za.co.absa.fadb.naming_conventions.lettersCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably lettersCase package should also be renamed
dk1844
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just read the code)
| pull_request: | ||
| branches: [ master, develop ] | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code of the license check seems ok, but I would expect it to have a direct effect - for the PR to actually launch the check -- which does not appear to be the case.
Could it be perhaps that the correct path should be lowercased? (.github/workflows/) as described in the doc?
| This library is a less traditional way to facilitate data between an application and an SQL Database. | ||
|
|
||
| Traditionally application directly applies SQL queries or use some ORM framework. While the first approach mixes two | ||
| rather different domain languages within one source, the second too often fails in case of more complicated queries and | ||
| table relations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This library is a less traditional way to facilitate data between an application and an SQL Database. | |
| Traditionally application directly applies SQL queries or use some ORM framework. While the first approach mixes two | |
| rather different domain languages within one source, the second too often fails in case of more complicated queries and | |
| table relations. | |
| This library is a less traditional way to facilitate data between an application and an SQL Database. | |
| Traditionally, an application directly applies SQL queries or uses an ORM framework. While the first approach mixes two | |
| rather different domain languages within one source, the second too often fails in case of more complicated queries and | |
| table relations. |
| import org.scalatest.matchers.should.Matchers | ||
| import org.scalatest.wordspec.AnyWordSpec | ||
| import za.co.absa.faDB.namingConventions.lettersCase.LettersCase._ | ||
| import za.co.absa.fadb.naming_conventions.letters_case.LettersCase._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import za.co.absa.fadb.naming_conventions.letters_case.LettersCase._ | |
| import za.co.absa.fadb.namingconventions.letterscases.LettersCase._ |
or
| import za.co.absa.fadb.naming_conventions.letters_case.LettersCase._ | |
| import za.co.absa.fadb.naming.letterscases.LettersCase._ |
While I am am aware that both this.is.a.possible.package_name and this.is.a.possible.packagename.too are conforming the general java/scala naming convention, I personally favor the latter.
AdrianOlosutean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good