Delete destination directory when exception occurred during ingestion#50
Merged
kevinwallimann merged 1 commit intodevelopfrom Oct 4, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: If e.g. one task fails writing, the ingestion will be incomplete and an IngestionException is thrown. However, the output directory is not cleaned up. For streaming queries, Spark does not yet delete the written files when a task is aborted. This is only planned with Spark v3.0.0 (https://issues.apache.org/jira/browse/SPARK-27254, https://issues.apache.org/jira/browse/SPARK-27210)
This PR: If an exception occurs during ingestion the destination directory is deleted, but only if it was empty before the ingestion started. If the destination directory was not empty in the beginning, it has to be cleaned up manually.