Feature/startingoffsets latest#55
Merged
kevinwallimann merged 4 commits intodevelopfrom Nov 5, 2019
Merged
Conversation
…erride the default "earliest" in absence of checkpoint-directory
jozefbakus
reviewed
Nov 5, 2019
| import za.co.absa.hyperdrive.ingestor.implementation.transformer.column.selection.ColumnSelectorStreamTransformer | ||
| import za.co.absa.hyperdrive.ingestor.implementation.transformer.factories.StreamTransformerAbstractFactory | ||
| import za.co.absa.hyperdrive.shared.configurations.ConfigurationsKeys.ColumnSelectorStreamTransformerKeys | ||
| import za.co.absa.hyperdrive.shared.configurations.ConfigurationsKeys.{ColumnSelectorStreamTransformerKeys, KafkaStreamReaderKeys} |
Collaborator
There was a problem hiding this comment.
KafkaStreamReaderKeys - Unused import statement ?
| @@ -58,7 +59,7 @@ private[manager] class CheckpointOffsetManager(val topic: String, val checkpoint | |||
|
|
|||
| if (startingOffsets.isDefined) { | |||
Collaborator
There was a problem hiding this comment.
I would rewrite if statement to something like this:
startingOffsets match {
case Some(startOffset) =>
logger.info(s"Setting starting offsets for topic '$topic' = $startOffset.")
streamReader.option(WORD_STARTING_OFFSETS, startOffset)
case None =>
logger.info(s"No offsets to set for topic '$topic'.")
streamReader
}
Collaborator
Author
There was a problem hiding this comment.
Btw you can use triple backticks ``` to make multiline code comments
jozefbakus
approved these changes
Nov 5, 2019
kevinwallimann
changed the base branch from
feature/partitioned-writer
to
develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.