Skip to content

Feature/project restructure#48

Merged
wajda merged 25 commits intodevelopfrom
feature/project-restructure
Nov 11, 2020
Merged

Feature/project restructure#48
wajda merged 25 commits intodevelopfrom
feature/project-restructure

Conversation

@wajda
Copy link
Copy Markdown
Contributor

@wajda wajda commented Nov 11, 2020

More testing is needed on a release & publish flows, hence a draft PR. Otherwise done.

Bullet points:

  • Project is Maven based, every module has a POM. Maven is responsible for the overall build cycle and macro dependency management, while delegating the individual build steps to the underlying module specific build tools (e.g. npm for JS modules).
  • Modules are made loosely coupled (via a maven repo) with no hard dependency on each other physical location.
  • Express module is removed due to redundancy, in favor of WAR & Docker modules
  • WAR & Docker modules are merged for simplicity - one codebase, two packaging types, trivial config
  • package.json versions are automatically sync'ed with their respective pom.xml ones on NPM postinstall phase

@wajda wajda marked this pull request as ready for review November 11, 2020 13:17
@wajda wajda force-pushed the feature/project-restructure branch from edba23c to 55d0c2a Compare November 11, 2020 13:56
@wajda wajda force-pushed the feature/project-restructure branch from 4c772af to 6c5b943 Compare November 11, 2020 15:55
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug D 10 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@wajda wajda merged commit 454df86 into develop Nov 11, 2020
@wajda wajda deleted the feature/project-restructure branch November 11, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants