(minor) Make Admin tool more talkative#1006
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| else Future.successful({}) | ||
| } yield {} |
There was a problem hiding this comment.
In my opinion, {} instead of Unit is making the code harder to understand.
There was a problem hiding this comment.
The reason why I removed Unit is because it is not an instance of the type Unit. The only instance of it is (). So the proper writing of the end of that for block would be one of these: yield (), yield {()} or yield {}
There was a problem hiding this comment.
OK, so it's correct. Still, it's a bit confusing. There is a Future.unit but only in Scala 2.12:
https://www.scala-lang.org/api/2.12.15/scala/concurrent/Future$.html#unit:scala.concurrent.Future[Unit]
Let's keep it as it is for now.
2 participants
Change log level of some messages from DEBUG to INFO to make the output slightly more verbose. For instance, create/drop collections, index, service etc.