spline #1011 test data generator module#1012
Conversation
AdrianOlosutean
force-pushed
the
feature/spline-1011-test-data-generator
branch
from
94bbfc9 to
5973323
Compare
…-v1.1' into feature/spline-1011-test-data-generator
…1-test-data-generator # Conflicts: # test-data-generator/src/main/scala/EventGenerator.scala
wajda
left a comment
wajda
left a comment
There was a problem hiding this comment.
In addition to the other comments, please move all the module source code to a corresponding package, say za.co.absa.spline.testdatagen. Also the directory src/test/java should be renamed to src/test/scala since it contains Scala files.
| programName("test-data-generator"), | ||
| head( | ||
| s""" | ||
| |Spline Data Generator |
There was a problem hiding this comment.
| |Spline Data Generator | |
| |Spline Test Data Generator |
| import org.scalatest.funsuite.AnyFunSuite | ||
| import za.co.absa.spline.producer.model.v1_2.{DataOperation, ExecutionEvent} | ||
|
|
||
| class PlanGeneratorTest extends AnyFunSuite { |
There was a problem hiding this comment.
In Spline, we rather prefer using BDD style for writing test. I'm not against AnyFunSuite per se, but AnyFlatSpec combined with should.Matchers offers more natural DSL for writing BDD style tests. Consider using that one. And instead of testing methods (generateWrite, generateRead) focus on cases (it should "generate one Write and two Reads when this and that condition is given" in { ... }").
|
Also, |
|
Sorry for flooding with comments, since in this PR we are creating a new module that is meant to be a CLI tool it would make sense to finish the POM part accordingly. Could you please add a |
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
Closes #1011
Added module for generating data for spline producer