spline #1034 Consumer API :: Data Source :: multi-value append filter#1035
Merged
Merged
Conversation
cerveada
reviewed
Mar 7, 2022
Comment on lines
+71
to
+72
| @ApiParam(value = "Write mode. Comma separated values of: `true` - append, `false` - overwrite, empty string - read only") | ||
| @RequestParam(value = "append", required = false) append: String, |
Contributor
There was a problem hiding this comment.
It seems weird that append = "" means that it's read. Wouldn't it be better to have three booleans for each or something like enum APPEND, OVERWRITE and READ?
Contributor
Author
There was a problem hiding this comment.
This API is a subject for a redesign, I don't want to spend much time on it.
cerveada
reviewed
Mar 8, 2022
cerveada
previously approved these changes
Mar 8, 2022
…est/model/WriteModeQuery.scala Co-authored-by: Adam Cervenka <adam.cervenka@absa.africa>
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer API: Allow for using multi-value filter on the write mode (
append) property