Skip to content

#1017 small code updates, no change in functionality #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dk1844 merged 2 commits into from
Aug 31, 2022
Merged

#1017 small code updates, no change in functionality #1103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1286e5
#1017 small code updates, no change in functionality
dk1844 Aug 31, 2022
3b0fa55
#1017 small code updates, no change in functionality
dk1844 Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions test-data-generator/src/main/scala/za/co/absa/spline/testdatagen/GenCLI.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ object GenCLI {

val configs: Seq[ExpandedConfig] = config.expand()

val dispatcher = createDispatcher("file", config)
val dispatcher = new FileDispatcher(createFileName(config))

configs.foreach(config => {
val graphType: Graph = Graph(config)
Expand All @@ -103,16 +103,11 @@ object GenCLI {
})
}

private def createDispatcher(name: String, config: Config): FileDispatcher = name match {
case "file" =>
config.customOutputFileName.fold {
new FileDispatcher(createDefaultFileName(config))
} { customFileName =>
new FileDispatcher(customFileName)
}
}

private def createDefaultFileName(config: Config): String = {
s"${config.graphType.name}-lineage-${config.reads}reads-${config.operations}ops-${config.attributes}attr.json.txt"
private def createFileName(config: Config): String = {
config.customOutputFileName match {
case None => // default name assembly
s"${config.graphType.name}-lineage-${config.reads}reads-${config.operations}ops-${config.attributes}attr.json.txt"
case Some(customName) => customName
}
}
}