develop-build fix on Windows (*-globbing in NPM)#1119
Merged
Conversation
…ing to LF replace unnecesary removals
|
Kudos, SonarCloud Quality Gate passed!
|
cerveada
approved these changes
Oct 21, 2022
dk1844
changed the title
*-globbing in NPM*-globbing in NPM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #1118.
In general, we have used
*-based globbing in a npm script which does not work on Windows. Nature of the problem outlined e.g. here. Even though some workaround can be attempted, in this particular case it was just easier to name the two concerned files literally.On another account LF endings are forced on
arangodb-fox-apimodule in order to address the second, linting, issue.Closes #1118