Bugfix/spline 1122 labels not working#1123
Merged
Merged
Conversation
|
SonarCloud Quality Gate failed.
|
cerveada
reviewed
Nov 4, 2022
Comment on lines
-36
to
+37
| new StringBuilder() | ||
| new mutable.StringBuilder() |
Contributor
Author
There was a problem hiding this comment.
It is - scala.collection.mutable.StringBuilder
Scala guide recommends to explicitly use mutable package name to clearly distinguish between mutable and immutable classes.
cerveada
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1122
The problem was in the incorrect serialization of
bindVarsto VPack. Specifically thelblValues:Array[Array[String]] -> Seq[...] -> Java -> VPack. The fix was to eliminate unnecessary conversions, and only passArray[Array[String]]types to VPack that do not require Scala to Java conversion and is properly supported.bindVarsserialization