spline #1131 Re-implement SPLINE::IS_VISIBLE_FROM_TX() function to pu…#1132
Merged
Conversation
Contributor
Author
|
@korel-san , any idea how to solve the unit test issue better? |
wajda
force-pushed
the
bugfix/spline-1131-aql-udf
branch
from
88c18d0 to
08dcbb7
Compare
wajda
force-pushed
the
bugfix/spline-1131-aql-udf
branch
from
08dcbb7 to
d0a7118
Compare
…pment mode calls in commons
…olve some linter warnings.
|
Kudos, SonarCloud Quality Gate passed!
|
cerveada
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re AQL
fixes #1131
SPLINE::IS_VISIBLE_FROM_TX()user defined function with inline AQL expressionsThe PR is still WIP because of missing unit tests. The included in the PR
aql-gen-helper.spec.ignore.tstest requires mocks for@arangodbmodule, particularly theaqlstring interpolator that is used for AQL code generation. I need to figure out how to either mock it properly, or use a real embedded database instance to run tests again.