spline #1193 Admin: add --dry-run option#1194
Conversation
| dryRunModeCaptor.getValue should be(true) | ||
| output should include("Dry-run mode activated") | ||
| } | ||
|
|
There was a problem hiding this comment.
Some "integration" test validating that when dry run is set there is no interaction with the parts of the code that should not be called, could be also useful. Maybe in different filet though.
There was a problem hiding this comment.
I thought about it, but it has to be an integration test with a real ArangoDB. Unfortunately capturing this behavior with mocks is impossible. Due to the nature of the ArangoDB driver there is no one place where you can intercept all write operations, or isolate all write method calls. The guard conditions are spread almost freely over the Admin codebase.
I'll see what I can do.
There was a problem hiding this comment.
added ArangoDb test container, fixtures and a couple of integration tests
wajda
force-pushed
the
feature/spline-1193-dry-run
branch
from
fe10eb8 to
dac967e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
fixes #1193