Reorder event call to emit correct accountAddress in AccountCreated event in AccountFactory example#48
Merged
jarrodwatts merged 1 commit intoAbstract-Foundation:mainfrom Jul 8, 2025
Conversation
Reordered AccountCreated event call to ensure the AccountCreated event emits the correct accountAddress.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@minebuu is attempting to deploy a commit to the Abstract Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordered AccountCreated event call to ensure the AccountCreated event emits the correct accountAddress.
PR-Codex overview
This PR focuses on the
AccountFactorycontract by ensuring that theAccountCreatedevent is emitted correctly after a new account is deployed.Detailed summary
AccountCreatedevent withaccountAddressandownerafter successful deployment.AccountCreatedevent with indexed parameters foraccountAddressandowner.