Skip to content

fix: don't output help unless --help or -h is passed #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: don't output help unless --help or -h is passed #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1e62fd
fix: don't output help unless --help or -h is passed
dalechyn Apr 15, 2024
155df50
chore: changesets
dalechyn Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gold-rats-search.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@abstract-money/cli": patch
---

Fixed a small issue where `--help` output was shown twice.
5 changes: 3 additions & 2 deletions packages/cli/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ void (async () => {
// Parse CLI args without running command
cli.parse(process.argv, { run: false })
if (!cli.matchedCommand) {
if (cli.args.length === 0) cli.outputHelp()
else throw new Error(`Unknown command: ${cli.args.join(' ')}`)
if (cli.args.length === 0) {
if (!cli.options.help && !cli.options.version) cli.outputHelp()
} else throw new Error(`Unknown command: ${cli.args.join(' ')}`)
}
await cli.runMatchedCommand()
} catch (error) {
Expand Down