-
Notifications
You must be signed in to change notification settings - Fork 33
Bump cw-orch and use MockBech32
#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MockBech32
Buckram123
reviewed
Feb 13, 2024
Collaborator
Buckram123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks VERY painful to do, noticed small nits
2 tasks
This was referenced Feb 16, 2024
Merged
CyberHoward
added a commit
that referenced
this pull request
Feb 16, 2024
This reverts commit 34148da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps cw-orch and uses bech32 mock because of instantiate2 use. Replaces #239.
Migrate tests get a fix here : #256
Checklist
Finish interchain tests
Replace cw-orch patch by published version when bech32 mock is released : First impl of Mock and MockBech32 cw-orchestrator#325
In framework
In modules
In integrations
In interchain
Replace cw-orch-interchain by tagged version when bech32 fix is released : https://github.com/AbstractSDK/cw-orch-interchain/pull/28
In interchain