Skip to content

Bump to 0.18.0 to fix cw-staking on osmosis#30

Merged
adairrr merged 11 commits intov0.17from
0.17-cw-staking-fix
Jul 28, 2023
Merged

Bump to 0.18.0 to fix cw-staking on osmosis#30
adairrr merged 11 commits intov0.17from
0.17-cw-staking-fix

Conversation

@Buckram123
Copy link
Copy Markdown
Collaborator

@Buckram123 Buckram123 commented Jul 28, 2023

Checklist

  • CI is green.
  • Changelog updated.

@Buckram123 Buckram123 requested a review from adairrr July 28, 2023 10:11
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jul 28, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82ced8a
Status:⚡️  Build in progress...

View logs

adairrr
adairrr requested changes Jul 28, 2023
View reviewed changes
Comment thread framework/packages/staking/src/msg.rs
Comment thread integrations/osmosis/packages/abstract-adapter/src/staking.rs
Comment thread integrations/osmosis/packages/abstract-adapter/src/staking.rs Outdated
Comment thread framework/packages/abstract-adapter/Cargo.toml Outdated
[package]
name = "abstract-adapter"
version = "0.17.2"
version = "0.17.3"
Copy link
Copy Markdown
Contributor

@adairrr adairrr Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a breaking change we theoretically should bump the minor version. This is important for other projects like the Cavern Protocol adapter. And we publish the packages separately from our contracts.

Copy link
Copy Markdown
Collaborator Author

@Buckram123 Buckram123 Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I rename branch to v0.18?

Copy link
Copy Markdown
Contributor

@adairrr adairrr Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No cause it's only the version of the packages.

Buckram123 and others added 2 commits July 28, 2023 14:14
@Buckram123 @adairrr
Update integrations/osmosis/packages/abstract-adapter/src/staking.rs
e1c4984 
Co-authored-by: adair <32375605+adairrr@users.noreply.github.com>
@Buckram123
bump to 0.18
f7d0a9b
@Buckram123 Buckram123 changed the title Bump to 0.17.3 to fix cw-staking on osmosis Bump to 0.18.0 to fix cw-staking on osmosis Jul 28, 2023
@Buckram123 Buckram123 requested a review from adairrr July 28, 2023 11:48
@adairrr
Copy link
Copy Markdown
Contributor

adairrr commented Jul 28, 2023

I suppose we should have some integration tests for these as well. Though we can deploy the current version for 4t2 later today to get them by for now.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 28, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v0.17@1d6a6cf). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             v0.17      #30   +/-   ##
========================================
  Coverage         ?   24.13%           
========================================
  Files            ?      270           
  Lines            ?    23382           
  Branches         ?        0           
========================================
  Hits             ?     5643           
  Misses           ?    17739           
  Partials         ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

adairrr
adairrr reviewed Jul 28, 2023
View reviewed changes
Comment thread integrations/astroport/packages/abstract-adapter/Cargo.toml
@adairrr adairrr merged commit 910d6cb into v0.17 Jul 28, 2023
@adairrr adairrr deleted the 0.17-cw-staking-fix branch July 28, 2023 17:27
@Buckram123 Buckram123 mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adairrr adairrr adairrr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Buckram123 @adairrr @codecov-commenter