Skip to content

Conversation

@CyberHoward
Copy link
Contributor

Removes the chainupload trait because it could be included in the TxHandler. This caused issues for the TxHandler implementation of the Mock as the trait could not be implemented for the generic Mock. We already came to the agreement that custom bindings are not the path forward with this crate or the Abstract framework. Hence I discided to remove them.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: da1144c
Status:⚡️  Build in progress...

View logs

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #141 (99593d9) into main (52de650) will not change coverage.
The diff coverage is 94.2%.

❗ Current head 99593d9 differs from pull request most recent head da1144c. Consider uploading reports for the commit da1144c to get more accurate results

Impacted Files Coverage Δ
cw-orch/src/daemon/traits.rs 93.7% <ø> (ø)
cw-orch/src/deploy.rs 0.0% <ø> (ø)
cw-orch/src/interface_traits.rs 65.0% <ø> (ø)
cw-orch/src/daemon/sync/core.rs 56.9% <87.5%> (ø)
cw-orch/src/contract.rs 89.6% <100.0%> (ø)
cw-orch/src/mock/core.rs 92.2% <100.0%> (ø)
packages/cw-orch-fns-derive/src/execute_fns.rs 94.5% <100.0%> (ø)
packages/cw-orch-fns-derive/src/query_fns.rs 97.1% <100.0%> (ø)

@CyberHoward CyberHoward merged commit 8eef5ee into main Jun 14, 2023
@CyberHoward CyberHoward deleted the remove/chainupload branch June 14, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants