Small Updates #282
Merged
Small Updates #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
e358fc5
|
| Status: | 🚫 Build failed. |
Codecov Report
Additional details and impacted files
|
Buckram123
approved these changes
Dec 4, 2023
Buckram123
reviewed
Dec 4, 2023
Buckram123
approved these changes
Dec 7, 2023
Contributor
Buckram123
left a comment
Buckram123
left a comment
There was a problem hiding this comment.
Will be nice to have a little test with 3+ contracts ( could be in another PR )
cw-orch/src/snapshots.rs
Outdated
| use ::cw_orch::environment::{ChainState as _, StateInterface as _}; | ||
| let all_contract_addresses = $chain.state().get_all_addresses()?; | ||
| let mut all_storage = ::std::collections::HashMap::new(); | ||
| let mut all_storage = vec![]; |
Contributor
There was a problem hiding this comment.
Why not use BTreeMap?
and nit: you can pass capacity of all_contract_addresses length for Vec here
Contributor
Author
There was a problem hiding this comment.
Hm, yeah better like so
Buckram123
reviewed
Dec 7, 2023
Comment on lines
+31
to
+42
| let all_contracts = $chain.state().get_all_addresses()?; | ||
| let all_storage: ::std::collections::BTreeMap<_, _> = all_contracts | ||
| .iter() | ||
| .map(|(id, contract_addr)| { | ||
| ( | ||
| id, | ||
| ::cw_orch::snapshots::parse_storage( | ||
| &$chain.app.borrow().dump_wasm_raw(&contract_addr), | ||
| ), | ||
| ) | ||
| }) | ||
| .collect(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.