fix: [ANS-2850] add referer header validation cache#31
Merged
ghiffari-agsarya merged 3 commits intomainfrom Jan 8, 2025
Merged
fix: [ANS-2850] add referer header validation cache#31ghiffari-agsarya merged 3 commits intomainfrom
ghiffari-agsarya merged 3 commits intomainfrom
Conversation
removed old Python version
anggorodewanto
approved these changes
Jan 8, 2025
Contributor
anggorodewanto
left a comment
anggorodewanto
left a comment
There was a problem hiding this comment.
Need documentation to explain to future us that this cache is for avoiding requesting to IAM if IAM's URL changed while the JWT being inspected is still using old URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added caching to GetClientInformation calls during referer header validation, cache lifetime is 60 seconds (1 minute). Based on Marsel suggestion https://accelbyte.slack.com/archives/C077YPGHWRF/p1730436581241239?thread_ts=1730433611.416489&cid=C077YPGHWRF