Skip to content

Conversation

@JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Mar 12, 2025

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.10.1 milestone Mar 12, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 12, 2025
@github-actions github-actions bot added the chore Jira issue-type "Task" label Mar 12, 2025
@github-actions
Copy link

github-actions bot commented Mar 12, 2025

Coverage Report

Commit:a91fe90
Base: develop@e37463c

Type Base This PR
Total Statements Coverage  70.87%  70.85%  (-0.02%)
Total Branches Coverage  70.83%  70.8%  (-0.03%)
Total Functions Coverage  83.76%  83.76%  (+0%)
Total Lines Coverage  70.87%  70.85%  (-0.02%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/DataExtract.js  84.37%  53.33%  100%  84.37%

@JoernBerkefeld JoernBerkefeld requested a review from Copilot March 12, 2025 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes changes to resolve the dataExtension dependency for dataExtract by updating metadata processing and dependency definitions, and by adjusting the corresponding test expectations.

  • Added dataExtension field lookups in both preDeployTasks and postRetrieveTasks in DataExtract.js.
  • Updated dependency definitions in DataExtract.definition.js to include dataExtension with a new dependencyGraph.
  • Adjusted test assertions in general, type.automation, and type.dataExtract test files reflecting additional API calls.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/metadataTypes/DataExtract.js Added logic for handling dataExtension in pre/post tasks and removed structuredClone.
lib/metadataTypes/definitions/DataExtract.definition.js Updated dependencies to include dataExtension and added a dependencyGraph entry.
test/general.test.js Increased API call count expectations due to added dependency resolution logic.
test/type.automation.test.js Reordered deployment types reflecting dependency change.
test/type.dataExtract.test.js Updated API call count assertions for dataExtract.
Comments suppressed due to low confidence (1)

lib/metadataTypes/DataExtract.js:246

  • [nitpick] Replacing structuredClone(metadata) with a direct return may expose metadata to unintended modifications if it is mutated later. Consider either reinstating cloning for immutability or documenting that the returned object is intentionally mutable.
return metadata;

@JoernBerkefeld JoernBerkefeld merged commit d8f6cb0 into develop Mar 12, 2025
12 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/2121-add-dataextension-as-dependency-of-dataextract branch March 12, 2025 09:42
@JoernBerkefeld JoernBerkefeld linked an issue Mar 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/dataExtension COMPONENT c/dataExtract COMPONENT chore Jira issue-type "Task"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] add dataExtension as dependency of dataExtract

2 participants