Skip to content

Conversation

@JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Mar 21, 2025

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.10.2 milestone Mar 21, 2025
@JoernBerkefeld JoernBerkefeld requested a review from Copilot March 21, 2025 14:31
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 21, 2025
@JoernBerkefeld JoernBerkefeld linked an issue Mar 21, 2025 that may be closed by this pull request
@github-actions github-actions bot added the chore Jira issue-type "Task" label Mar 21, 2025
@JoernBerkefeld JoernBerkefeld added the c/automation COMPONENT label Mar 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances automation processing by re-retrieving automation items after they are paused or scheduled, ensuring that local files are updated accordingly.

  • Introduces a new Retriever instance to re-retrieve automation items.
  • Adds logging for caching and error conditions during the re-retrieval process.
Comments suppressed due to low confidence (2)

lib/metadataTypes/Automation.js:779

  • Verify that the parameters passed to retriever.retrieve match its expected signature in Retriever.js. It appears that an array of metadata types and an array of keys are being used, so please confirm this behavior is intentional.
await retriever.retrieve([this.definition.type], updatedKeyArr);

lib/metadataTypes/Automation.js:781

  • [nitpick] Consider including additional diagnostic details or the error stack in the log to facilitate troubleshooting, rather than relying solely on ex.message.
Util.logger.warn(`Could not re-retrieve ${mode === 'schedule' ? 'activated' : 'paused'} ${this.definition.type}s: ${ex.message}`);

@github-actions
Copy link

github-actions bot commented Mar 21, 2025

Coverage Report

Commit:c316cdb
Base: develop@f4ff9ba

Type Base This PR
Total Statements Coverage  70.7%  70.7%  (+0%)
Total Branches Coverage  70.87%  70.9%  (+0.03%)
Total Functions Coverage  83.01%  83.01%  (+0%)
Total Lines Coverage  70.7%  70.7%  (+0%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit c6c0ab3 into develop Mar 21, 2025
12 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/2111-re-retrieve-automation-after-running-schedule branch March 21, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/automation COMPONENT chore Jira issue-type "Task"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] re-retrieve automation after running schedule

2 participants