feature/2427 allow adding like-filters to createDeltaPkg source-marketList#2428
Merged
JoernBerkefeld merged 3 commits intodevelopfrom Nov 20, 2025
Conversation
Coverage ReportCommit:9f9ab2dBase: develop@89d0429 Details (changed files):
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for include/exclude filters in market lists when creating delta packages. The filters use SQL LIKE-style patterns (with % and _ wildcards) to selectively process metadata items based on their keys.
Key Changes:
- Market list configurations can now include a
filterproperty withinclude.keyandexclude.keyarrays - Filter patterns are applied during template building to remove unwanted items from processing
- Exclude filters are applied first, followed by include filters
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/util/util.js | Updated BU validation to skip the new 'filter' property when iterating market list keys |
| lib/util/devops.js | Extracts filter from source market list and passes it to the build function |
| lib/index.js | Implements filter logic in buildTemplate() to apply include/exclude patterns to metadata keys |
| @types/lib/index.d.ts | Added optional filter parameter to build() and buildTemplate() method signatures |
| @types/lib/util/util.d.ts.map | Updated TypeScript source map |
| @types/lib/util/devops.d.ts.map | Updated TypeScript source map |
| @types/lib/index.d.ts.map | Updated TypeScript source map |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR details
What changes did you make? (Give an overview)
Further details (optional)
Checklist