Skip to content

refactor!: Make Node opaque and optimize it for size #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwcampbell merged 46 commits into from
Feb 5, 2023
Merged

refactor!: Make Node opaque and optimize it for size #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
282e26f
refactor!: Make `accesskit::Node` opaque so we can optimize it
mwcampbell Jan 7, 2023
83c17d1
Switch to table-based properties for anything larger than 1 byte; ser…
mwcampbell Jan 8, 2023
200a86e
Fix irregularity in property method names
mwcampbell Jan 8, 2023
727ea59
Fix irregularity in internal property type naming
mwcampbell Jan 8, 2023
85bcbad
Use macros to define the methods for the dynamic properties
mwcampbell Jan 8, 2023
e7743e2
Fix references to NodeProvider in doc comments, left over from an aba…
mwcampbell Jan 8, 2023
407e979
Refactor to allow Node to derive Default again
mwcampbell Jan 8, 2023
54a3163
Use a macro for the various optional enum fields
mwcampbell Jan 8, 2023
cdd2aa2
Use macros for all the flag getter/setter methods
mwcampbell Jan 8, 2023
6a638d8
Remove old workaround for feature/dependency name collision
mwcampbell Jan 8, 2023
7b11644
Use EnumSet to compactly represent flags
mwcampbell Jan 8, 2023
c017106
Drop has_aria_attribute; pretty sure that was just an internal detail…
mwcampbell Jan 8, 2023
aadb0fd
Likewise, not_user_selectable_style is very Chromium-specific. Now we…
mwcampbell Jan 8, 2023
3204e38
Remove some more Chromium-internal properties that we don't need. Now…
mwcampbell Jan 8, 2023
1358b30
Implement Serialize; stub Deserialize
mwcampbell Jan 9, 2023
516966f
Implement deserialization
mwcampbell Jan 9, 2023
fbaf07b
Correctly use Option when serializing
mwcampbell Jan 9, 2023
c6d5a3e
Forgot to make the field ID enum serialize as camel-case
mwcampbell Jan 9, 2023
af12230
Drop skip_serializing_if attribute; it's not safe for all data formats
mwcampbell Jan 9, 2023
e2f2c58
Box the two largest property value types
mwcampbell Jan 10, 2023
cc08211
reformat
mwcampbell Jan 10, 2023
7451175
Rename the Property enum to PropertyValue to indicate that it contain…
mwcampbell Jan 12, 2023
2285cda
Change macro syntax so lists are comma-delimited as one would expect
mwcampbell Jan 12, 2023
40222cb
Go back to not wrapping Node in Arc at the API level
mwcampbell Jan 12, 2023
a7ccaeb
Eliminate the dependency on the heavy proc-macro-based enumset
mwcampbell Jan 13, 2023
b7966fb
We no longer need serde's rc feature
mwcampbell Jan 13, 2023
f24087f
Absorb the bits of kurbo we need rather than depending on and re-expo…
mwcampbell Jan 14, 2023
bd14914
Use enumn rather tha num-traits and num-derive
mwcampbell Jan 14, 2023
28d5421
Eliminate the dependency on paste in the accesskit crate. No mandator…
mwcampbell Jan 14, 2023
5c42842
Fix awkward method naming forced by the previous macros
mwcampbell Jan 14, 2023
694e471
Store everything optional as a property, even the optional bools and …
mwcampbell Jan 14, 2023
58780c9
Reorder code slightly
mwcampbell Jan 14, 2023
5c44cfe
Introduce the concept of a node class
mwcampbell Jan 14, 2023
855004e
Split node setters out into NodeBuilder, to enable more optimizations
mwcampbell Jan 14, 2023
9f33e78
The payoff: shared node classes
mwcampbell Jan 14, 2023
7a11daa
accesskit::Node now uses Arc internally, so don't use it in the consu…
mwcampbell Jan 14, 2023
f25a3ab
Do the unexpected-property-type panic in just one place
mwcampbell Jan 14, 2023
af4d246
Reduce boilerplate with some new macros
mwcampbell Jan 15, 2023
81c4d74
Implement schemars support for the new node struct
mwcampbell Jan 15, 2023
5ca9bb6
Eliminate use of a too-recently-stabilized library feature
mwcampbell Jan 15, 2023
e750009
Got the version number wrong in the comment
mwcampbell Jan 15, 2023
542b526
Fix clippy
mwcampbell Jan 15, 2023
3949b7d
Make the shared node class set explicit; also clean up examples
mwcampbell Jan 22, 2023
19d863f
Back to bare panics for unexpected property types, to keep the runtim…
mwcampbell Jan 22, 2023
b1b4f82
Add inlining hints to simple functions for the benefit of projects th…
mwcampbell Jan 22, 2023
c5606ab
Merge branch 'main' into opaque-node
mwcampbell Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 6 additions & 83 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 5 additions & 6 deletions common/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@ edition = "2021"
features = ["schemars", "serde"]

[dependencies]
enumset = "1.0.8"
kurbo = "0.8.3"
schemars_lib = { package = "schemars", version = "0.8.7", features = ["enumset"], optional = true }
serde_lib = { package = "serde", version = "1.0", features = ["derive", "rc"], optional = true }
enumn = { version = "0.1.6", optional = true }
schemars = { version = "0.8.7", optional = true }
serde = { version = "1.0", features = ["derive"], optional = true }

[features]
schemars = ["serde", "schemars_lib", "kurbo/schemars"]
serde = ["serde_lib", "enumset/serde", "kurbo/serde"]
serde = ["dep:serde", "enumn"]
schemars = ["dep:schemars", "serde"]
Loading