feat: Expose text properties on consumer Node with inheritance
#617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
reviewed
Sep 26, 2025
Member
DataTriny
left a comment
DataTriny
left a comment
There was a problem hiding this comment.
Looks good to me. With all of these identical methods, have you considered a macro though? We would loose readability but it would make it easier to write unit tests, which is also important.
DataTriny
approved these changes
Oct 8, 2025
Member
|
@mwcampbell You can merge this after running cargo fmt. |
DataTriny
force-pushed
the
inherited-text-properties
branch
from
e609932 to
547b342
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step toward exposing text formatting in the platform APIs. I added all of the text properties that I thought should be inherited from the nearest ancestor that has the property set. I'm not sure if any of the booleans should be inherited. I guess we should also decide on a convention for documenting that a given property is inherited; right now, we only document that on a couple of properties.