Skip to content

Conversation

@lukewarlow
Copy link
Contributor

Fixes #639

@lukewarlow lukewarlow changed the title Extend AriaRoleProperty in windows adaptor feat: Extend AriaRoleProperty in windows adaptor Nov 21, 2025
Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just noticed some missing roles, but I am pretty sure there are more.

@lukewarlow
Copy link
Contributor Author

lukewarlow commented Nov 23, 2025

Ah yeah it seems the documentation from microsoft isn't very complete (along with some accesskit specific additions, I'm looking at them now to try and work out what's missing.

I don't think I'll be able to get it fully right in the first run through but hopefully most of the standard ones will be mapped correctly. I'm especially not looking at DPub.

@lukewarlow
Copy link
Contributor Author

Where a role exists in one of the core aria role definitons I've mapped it verbatim, other Chromium/AccessKit extras I've tried to map as best as possible (most are from looking at Chromium's source code in their ax_platform_node_win.cc)

Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite exhaustive. Thanks! I think Servo is the only context in which we'd be able to identify what's missing now.

@DataTriny DataTriny merged commit 4b8e01a into AccessKit:main Nov 28, 2025
16 checks passed
@DataTriny DataTriny mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should UIA_AriaRolePropertyId be set for the Windows adaptor?

2 participants