-
Notifications
You must be signed in to change notification settings - Fork 88
feat: Extend AriaRoleProperty in windows adaptor #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
34fbd33 to
40e5a65
Compare
DataTriny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just noticed some missing roles, but I am pretty sure there are more.
|
Ah yeah it seems the documentation from microsoft isn't very complete (along with some accesskit specific additions, I'm looking at them now to try and work out what's missing. I don't think I'll be able to get it fully right in the first run through but hopefully most of the standard ones will be mapped correctly. I'm especially not looking at DPub. |
cfbb20c to
9ed032a
Compare
|
Where a role exists in one of the core aria role definitons I've mapped it verbatim, other Chromium/AccessKit extras I've tried to map as best as possible (most are from looking at Chromium's source code in their ax_platform_node_win.cc) |
DataTriny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite exhaustive. Thanks! I think Servo is the only context in which we'd be able to identify what's missing now.
Fixes #639