Fix test assertions and mock cleanup per code review#31
Merged
AccessiT3ch merged 3 commits intotest/phase1.5-test-coveragefrom Feb 1, 2026
Merged
Fix test assertions and mock cleanup per code review#31AccessiT3ch merged 3 commits intotest/phase1.5-test-coveragefrom
AccessiT3ch merged 3 commits intotest/phase1.5-test-coveragefrom
Conversation
…Null and fix window.open mocking Co-authored-by: AccessiT3ch <95449364+AccessiT3ch@users.noreply.github.com>
…undant test Co-authored-by: AccessiT3ch <95449364+AccessiT3ch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Establish test coverage baseline for RedCards application
Fix test assertions and mock cleanup per code review
Feb 1, 2026
AccessiT3ch
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on test quality and configuration safety from PR #26.
Test Assertions
Replaced
toBeDefined()withnot.toBeNull()forquerySelector()results (12 instances across 3 files).toBeDefined()passes fornull, creating false positives:Mock Hygiene
Saved and restored
window.openin 4errorBoundary.test.jsxtests to prevent leakage between test runs.Code Cleanup
.vscode/settings.json(auto-approvedgit push/git commit- unsafe for contributors/CI)NavigatableRightshelper and imports fromrights.test.jsx💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.