Skip to content

Conversation

@UnschooledGamer
Copy link
Member

Why should this PR be merged

This pull request adds an option that allows users to toggle whether they want the current file to be used for preview in the browser or the default index.html.

In addition The PR adds workflows for paid dev and prod version.

⬆️ Whys & Changes

  1. (MAIN) Updated the Github actions used in the workflow to avoid warning & deprecation issues.
  2. forceRun option so that the workflow can run in forks
  3. Checking if it runs in deadlyjack/Acode Only
  4. Skips the build process if The commit message contains skip ci.

⚙️Changes

  • option to choose Current file or default for browser preview.
  • Fixed build dirs not being created in setup.js script.
  • excluded *.apk(anything that ends with .apk) in .gitignore.

Thanks for the efforts from @WebLeach

Lastly, Inform me If I missed out something to remove, add Or include.

Thank You.

UnschooledGamer and others added 30 commits August 12, 2024 08:03
@deadlyjack
Copy link
Collaborator

Hi, thanks for this PR, seems to be a great feature. Although workflow for building the app needs to be a separate PR.

@UnschooledGamer
Copy link
Member Author

Hi, thanks for this PR, seems to be a great feature. Although workflow for building the app needs to be a separate PR.

@deadlyjack Welcome, But Another Separate for That is a bit more. As 2 PRs already exist for It. And My Changes just include Version Upgradation of The GitHub Actions used in the workflows itself.

Removed As [Ajit wants another PR](Acode-Foundation#1006 (comment)) just for GitHub Actions version Update. And That's not suitable to me atleast. So Goodbye Workflows
@bajrangCoder bajrangCoder requested review from bajrangCoder and removed request for deadlyjack August 24, 2024 09:57
@bajrangCoder bajrangCoder self-assigned this Aug 24, 2024
@bajrangCoder bajrangCoder added the enhancement New feature or request label Aug 24, 2024
@bajrangCoder bajrangCoder merged commit f7613d6 into Acode-Foundation:main Aug 24, 2024
@UnschooledGamer UnschooledGamer deleted the feat/useCurrentFileForPreview branch August 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants