Skip to content

Follow up for #1110 #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 22, 2024
Merged

Follow up for #1110 #1112

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a71c00
minor fixes and tweaks
bajrangCoder Dec 14, 2024
2537c64
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Dec 17, 2024
8598b19
fix: network issue while making request to ipv4, etc
bajrangCoder Dec 17, 2024
5a86c96
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Dec 18, 2024
bbd4a2f
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Dec 18, 2024
d5896c6
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Dec 19, 2024
6157f70
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Dec 19, 2024
df4f1e1
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Dec 22, 2024
0b9fc0f
follow up for #1110 to handle lazy loading
bajrangCoder Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/inputhints/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,11 @@ export default function inputhints($input, hints, onSelect) {
}

function updatePage() {
const offset = (pages + 1) * LIMIT;
const hasMore = offset < currentHints.length;

// if the scroll is at the bottom
if ($ul.scrollTop + $ul.clientHeight >= $ul.scrollHeight) {
if ($ul.scrollTop + $ul.clientHeight >= $ul.scrollHeight && hasMore) {
pages++;
updateUlNow(currentHints, pages);
}
Expand Down Expand Up @@ -311,8 +314,11 @@ export default function inputhints($input, hints, onSelect) {

$ul.remove();

if (!list.length) {
if (!hints.length) {
$ul.content = [<Hint hint={{ value: "", text: "No matches found" }} />];
} else if (!list.length) {
// No more hints to load
return;
} else {
if (!page) {
scrollTop = 0;
Expand Down
Loading